Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAD-1906: Alonzo transactions and serialisation #2055

Merged
merged 4 commits into from
Dec 11, 2020
Merged

CAD-1906: Alonzo transactions and serialisation #2055

merged 4 commits into from
Dec 11, 2020

Conversation

nc6
Copy link
Contributor

@nc6 nc6 commented Dec 10, 2020

This PR adds:

  • Alonzo era transactions
  • Serialisation and tests for Tx and TxBody

Also it fixes a bunch of warnings.

Adds a test (and necessary infrastructure) for serialisation and
deserialisation of Alonzo-era TxBody.
- Introduce the transaction type for Alonzo
- Introduce serialisation code for transactions. Note that currently,
  the transaction serialisation does _not_ allow Shelley/Allegra/Mary
  era transactions to decode directly as Alonzo transactions. If we
  decide that we should do this, it should not be particularly difficult
  to allow this, but since we do not sign transactions directly, we may
  simply convert old to new transactions and know that the TxBody will
  still have the correct hash.
- Add a round-trip test for Tx serialisation.
Copy link
Contributor

@JaredCorduan JaredCorduan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! thanks!

@nc6 nc6 merged commit da2d8ba into master Dec 11, 2020
@iohk-bors iohk-bors bot deleted the nc/cad-1906 branch December 11, 2020 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants